Skip to content

Fix nullable & required properties in multipart bodies #995

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 18, 2024

Conversation

dbanty
Copy link
Collaborator

@dbanty dbanty commented Mar 9, 2024

WIP Fix for #926

@johnthagen
Copy link
Collaborator

@dbanty Anything else I can help test with this MR?

@dbanty
Copy link
Collaborator Author

dbanty commented May 18, 2024

@johnthagen I totally lost track of this PR, sorry! I think that the logic is now roughly the same as what it was in 0.16 and prior. However, I'm realizing that encoding None as a string is almost definitely the wrong behavior. I haven't actually used multipart in many years at this point—are you aware of a convention for sending a literal null? Should we just be omitting the value like we do for query params?

@dbanty
Copy link
Collaborator Author

dbanty commented May 18, 2024

Since this version is strictly better than what's before it (and I think really close to 0.16), I'm going to merge as-is. We can address passing nulls via multipart once someone reports a real-world need for it.

@dbanty dbanty merged commit 84d9844 into main May 18, 2024
20 checks passed
@dbanty dbanty deleted the fix-nullable-multipart-primative branch May 18, 2024 19:47
@johnthagen
Copy link
Collaborator

@dbanty Thanks and I think your plan sounds great! I'll also test the 0.20 release and report back to you.

@johnthagen
Copy link
Collaborator

@dbanty Confirmed that 0.20.0 resolved #926 and everything else appears to be working fine with it too. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants